Update object_class.rst , updating connect()'s code sample and relevant explanation #11341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be updated and working
AThousandShips
requested changes
Oct 6, 2025
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: A Thousand Ships <[email protected]>
Calinou
reviewed
Oct 6, 2025
Calinou
approved these changes
Oct 6, 2025
AThousandShips
approved these changes
Oct 7, 2025
AThousandShips
added
enhancement
area:engine details
mhilbrunner
approved these changes
Oct 9, 2025
|
Thank you! And thanks everyone for the reviews. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated as some of the function signatures have changed.
also wrote some explanations for the new function signatures but might need another eye to look over the way I described the new function signatures for connect()